Skip to content

Conversation

@oshoval
Copy link
Contributor

@oshoval oshoval commented Nov 13, 2025

What this PR does / why we need it:
In order to allow using DRA driver,
export KUBEVIRT_USE_DRA=true.

It will skip installing the DP and CNI, and install DRA driver (includes sriov-cni) instead.

We still create VFs, and unbind them.
It suits vfio driver of DRA.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 13, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval oshoval changed the title WIP: Allow to use DRA kind-sriov: Allow to use DRA Nov 16, 2025
@oshoval oshoval marked this pull request as ready for review November 17, 2025 08:11
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@oshoval
Copy link
Contributor Author

oshoval commented Nov 17, 2025

/retest

1 similar comment
@oshoval
Copy link
Contributor Author

oshoval commented Nov 19, 2025

/retest

Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @oshoval.
I recommend re-framing it as "disable deployment of SR-IOV DP and CNI".
DRA may be the catalyst behind this change, but it does not directly relate to it.

@oshoval
Copy link
Contributor Author

oshoval commented Nov 27, 2025

@orelmisan

In the future it will also install DRA driver, for now since the DRA driver still has a bug, it doesn't install it.
So i can change the title, but prefer to keep KUBEVIRT_USE_DRA, as it allows to use DRA by removing the other components, and soon will also allow to install the driver itself.
(so it is basically related to it, even now, as DRA replaces the tuple, hence we remove it to allow DRA to be installed instead)

wdyt?

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @orelmisan - can you expand the PR description to explain why we need this?

@orelmisan
Copy link
Member

orelmisan commented Nov 27, 2025

@orelmisan

In the future it will also install DRA driver, for now since the DRA driver still has a bug, it doesn't install it. So i can change the title, but prefer to keep KUBEVIRT_USE_DRA, as it allows to use DRA by removing the other components, and soon will also allow to install the driver itself. (so it is basically related to it, even now, as DRA replaces the tuple, hence we remove it to allow DRA to be installed instead)

wdyt?

If we don't need it right away, we can wait until it does something useful or say what it actually does.

@oshoval
Copy link
Contributor Author

oshoval commented Nov 27, 2025

Updated, we do need it for development, and plan to demo it once this PR and some more are merged.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New security issues found

@kubevirt-bot
Copy link
Contributor

@sourcery-ai[bot]: changing LGTM is restricted to collaborators

In response to this:

New security issues found

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oshoval
Copy link
Contributor Author

oshoval commented Dec 2, 2025

Since needed PRs were merged on Kubevirt and DRA driver,
now the PR also deploys DRA driver.

Rest of the changes to support DRA network devices will be on Kubevirt.
i.e kubevirt/kubevirt#16249
adapting the API (atm supports feature gated HostDevice only), and afterward support migration.
But there is still lot of design / work there to do.

@oshoval
Copy link
Contributor Author

oshoval commented Dec 2, 2025

failures are not related, this PR basically shouldn't even run those, it is just because there is a commit without tag yet, so provision manager runs it meanwhile

@oshoval oshoval changed the title kind-sriov: Allow to use DRA kind-sriov: Allow to use DRA driver Dec 2, 2025
In order to allow using DRA driver,
export KUBEVIRT_USE_DRA=true.

It will skip installing the DP and CNI, and install DRA driver instead.

We still create VFs, and unbind them.
It suits vfio driver of DRA.

Manifest was generated with

helm template sriov-dra \
  ./deployments/helm/dra-driver-sriov/ \
  --set image.tag=$(git rev-parse --short=7 HEAD) \
  -n dra-driver-sriov | \
  sed '/helm.sh\/chart:/d' | \
  sed '/app.kubernetes.io\/version:/d' | \
  sed '/app.kubernetes.io\/managed-by: Helm/d'

Signed-off-by: Or Shoval <[email protected]>
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Dec 2, 2025

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-provision-k8s-1.32 145e7a8 link true /test check-provision-k8s-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement sig/network size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants