-
Notifications
You must be signed in to change notification settings - Fork 137
kind-sriov: Allow to use DRA driver #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/retest |
1 similar comment
|
/retest |
orelmisan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @oshoval.
I recommend re-framing it as "disable deployment of SR-IOV DP and CNI".
DRA may be the catalyst behind this change, but it does not directly relate to it.
|
In the future it will also install DRA driver, for now since the DRA driver still has a bug, it doesn't install it. wdyt? |
brianmcarey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @orelmisan - can you expand the PR description to explain why we need this?
If we don't need it right away, we can wait until it does something useful or say what it actually does. |
|
Updated, we do need it for development, and plan to demo it once this PR and some more are merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New security issues found
cluster-up/cluster/kind-sriov/sriov-components/manifests/dra/sriov_dra.yaml
Show resolved
Hide resolved
|
@sourcery-ai[bot]: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Since needed PRs were merged on Kubevirt and DRA driver, Rest of the changes to support DRA network devices will be on Kubevirt. |
|
failures are not related, this PR basically shouldn't even run those, it is just because there is a commit without tag yet, so provision manager runs it meanwhile |
In order to allow using DRA driver, export KUBEVIRT_USE_DRA=true. It will skip installing the DP and CNI, and install DRA driver instead. We still create VFs, and unbind them. It suits vfio driver of DRA. Manifest was generated with helm template sriov-dra \ ./deployments/helm/dra-driver-sriov/ \ --set image.tag=$(git rev-parse --short=7 HEAD) \ -n dra-driver-sriov | \ sed '/helm.sh\/chart:/d' | \ sed '/app.kubernetes.io\/version:/d' | \ sed '/app.kubernetes.io\/managed-by: Helm/d' Signed-off-by: Or Shoval <[email protected]>
|
@oshoval: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
In order to allow using DRA driver,
export KUBEVIRT_USE_DRA=true.It will skip installing the DP and CNI, and install DRA driver (includes sriov-cni) instead.
We still create VFs, and unbind them.
It suits vfio driver of DRA.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: