fix: code quality and safety improvements - #330
Conversation
🎉 Welcome to CodeLens — Thank You for Your Contribution!Hey @saurabhhhcodes! 👋 We are genuinely excited to have you here. Every single PR — big or small — makes CodeLens better, and yours is no exception. Take a moment to review the checklist below to help us merge your work quickly and smoothly. ✅ Before Requesting a Review
💬 Join Our Community Channel — This is MandatoryBeing part of our communication channel is compulsory for all contributors, not optional. Why join? This is where all important announcements, PR review updates, contribution discussions, and maintainer decisions happen in real time. Contributors who are not in the channel regularly miss critical context and updates, which often leads to duplicated or misaligned work. Staying connected here is what keeps the community strong and your contributions impactful. We are rooting for you! If you have any questions, drop them in the channel or comment right here on this PR. Let's build something great together. 🚀✨ |
📝 WalkthroughWalkthroughThe GitHub service now attaches a catch handler to per-repository language fetches. The handler logs retrieval errors instead of leaving promise rejections unhandled. ChangesGitHub language retrieval
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.5)server/modules/github/service.jsFile contains syntax errors that prevent linting: Line 179: expected Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@server/modules/github/service.js`:
- Line 179: Repair GitHubService by moving error handling into each promise
created by topRepos.map, ensuring Promise.all receives the mapped fetch promises
rather than chaining .catch onto the resulting array. Restore the repoLanguages
aggregation, `#fetchDashboardData` implementation, remaining dashboard methods,
class closing brace, and export default GitHubService so the service is
syntactically complete.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f7edcad1-3de6-4725-87bc-ee757fbec249
📒 Files selected for processing (1)
server/modules/github/service.js
| } | ||
|
|
||
| export default GitHubService; | ||
| .catch(err => console.error(err)) No newline at end of file |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
node --check server/modules/github/service.js
rg -n 'static async getDashboard|static async syncDashboard|export default GitHubService;' \
server/modules/github/service.jsRepository: kunalverma2512/CodeLens
Length of output: 421
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "## service.js end"
sed -n '130,190p' server/modules/github/service.js
echo
echo "## apexContextCompiler.js references"
rg -n 'langByBytes|GithubData|data\.langs|github' server/utils/apexContextCompiler.js
echo
echo "## full service symbols/length"
wc -l server/modules/github/service.js
rg -n 'class GitHubService|static async getDashboard|static async syncDashboard|export default GitHubService|topRepos|Promise\.all|langByBytes' server/modules/github/service.jsRepository: kunalverma2512/CodeLens
Length of output: 3554
🌐 Web query:
CodeLens kunalverma2512 server/modules/github/service.js repoLanguages Promise.all topRepos map langByBytes
💡 Result:
In the context of the CodeLens project by kunalverma2512 [1][2], the code pattern involving repoLanguages, Promise.all, topRepos, map, and langByBytes refers to a common approach for aggregating and visualizing programming language usage across a user's top GitHub repositories [3][4]. This implementation typically follows this workflow: 1. Fetching Top Repositories: The application first retrieves a list of a user's repositories (often filtered or sliced to identify the "top" repositories, e.g., the first 12) [3][4]. 2. Concurrent Data Fetching: It uses map to create an array of promises, each calling a service function (often named repoLanguages or similar) to fetch the language statistics for an individual repository via the GitHub API endpoint GET /repos/:owner/:repo/languages [3][4][5]. 3. Promise.all: The Promise.all function is used to execute these requests concurrently, significantly reducing the total time required to gather data for all repositories [3][4]. 4. Aggregating by Bytes: Once all language data is resolved, the code iterates through the resulting objects (which map language names to their byte count) to calculate a cumulative total of bytes per language across all selected repositories [3][4]. This often involves creating an aggregated or langByBytes object where language keys are updated by adding the byte counts returned by each repository [3][4]. This pattern is a standard architectural choice in dashboard applications to handle the latency of multiple sequential network requests to the GitHub API [3][4]. Similar implementations are found in various GitHub dashboard projects and technical discussions regarding language usage visualization [3][4][5].
Citations:
- 1: https://github.com/kunalverma2512/CodeLens
- 2: https://github.com/kunalverma2512
- 3: https://mintlify.wiki/David-Andino/github-dashboard/development/use-github-hook
- 4: https://mintlify.wiki/David-Andino/github-dashboard/development/components/language-chart
- 5: https://stackoverflow.com/questions/74867559/github-api-requests-to-get-language-usage
Restore the missing service body and fix the language-fetch promise chain.
server/modules/github/service.js exits at line 179 with a syntax error: .catch(...) is attached to the array returned by topRepos.map(...), and repoLanguages = await Promise.all(..., #fetchDashboardData, GitHubService, and export default GitHubService; are left unclosed. Move the error handling into each mapped fetch promise and restore the deleted aggregations, dashboard methods, class brace, and export.
🧰 Tools
🪛 Biome (2.5.5)
[error] 179-179: expected ) but instead the file ends
(parse)
🪛 GitHub Actions: Quality Gate / 0_Backend Lint & Test.txt
[error] 179-179: ESLint parsing error: Unexpected token. The 'npm run lint' command failed with exit code 1.
🪛 GitHub Actions: Quality Gate / Backend Lint & Test
[error] 179-179: ESLint parsing error: Unexpected token. The 'npm run lint' command failed with exit code 1.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@server/modules/github/service.js` at line 179, Repair GitHubService by moving
error handling into each promise created by topRepos.map, ensuring Promise.all
receives the mapped fetch promises rather than chaining .catch onto the
resulting array. Restore the repoLanguages aggregation, `#fetchDashboardData`
implementation, remaining dashboard methods, class closing brace, and export
default GitHubService so the service is syntactically complete.
Source: Linters/SAST tools
1 participant
Summary by CodeRabbit