Skip to content

fix(brief): pin decision key placement in generated briefs - #1969

Closed
eduardstan wants to merge 6 commits into
kunchenguid:mainfrom
eduardstan:fm/brief-key-position
Closed

fix(brief): pin decision key placement in generated briefs#1969
eduardstan wants to merge 6 commits into
kunchenguid:mainfrom
eduardstan:fm/brief-key-position

Conversation

@eduardstan

Copy link
Copy Markdown

Problem

bin/fm-classify-lib.sh requires [key=<slug>] between the status verb and the colon, but the generated scaffolds did not say so. Workers therefore wrote keys at the end of status lines, and the key never registered.

Changes

  • Clarified parser-accepted key placement in ship, scout, and secondmate briefs.
  • Added regression coverage for the incident line and correctly placed keys.
  • Kept the parser strict because trailing bracketed prose is ambiguous.

Validation: tests/fm-brief.test.sh, focused classifier coverage, tests/fm-send-resolve-key.test.sh, and bin/fm-lint.sh pass.

@eduardstan

Copy link
Copy Markdown
Author

The required PR must be raised via no-mistakes check fails here because this branch was pushed directly rather than through that pipeline. I will re-raise the same change through the required path and close this one; no review time is needed on it in the meantime.

@eduardstan

Copy link
Copy Markdown
Author

Superseded by #2168, which carries the same change raised through the required no-mistakes pipeline.

@eduardstan eduardstan closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant