fix(brief): pin decision key placement in generated briefs - #1969
Closed
eduardstan wants to merge 6 commits into
Closed
fix(brief): pin decision key placement in generated briefs#1969eduardstan wants to merge 6 commits into
eduardstan wants to merge 6 commits into
Conversation
Render decision keys between the status verb and colon in ship, scout, and secondmate briefs. Keep the classifier strict because trailing bracketed prose is ambiguous; cover the incident line and preserve its historical default key.
Author
|
The required |
Author
|
Superseded by #2168, which carries the same change raised through the required no-mistakes pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bin/fm-classify-lib.shrequires[key=<slug>]between the status verb and the colon, but the generated scaffolds did not say so. Workers therefore wrote keys at the end of status lines, and the key never registered.Changes
Validation:
tests/fm-brief.test.sh, focused classifier coverage,tests/fm-send-resolve-key.test.sh, andbin/fm-lint.shpass.