fix(bearings): gate unreclaimed completed work - #1985
Open
coreldh wants to merge 2 commits into
Open
Conversation
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Republish PR 1735 cleanly from current main without rebasing or resurrecting its stale head. Close only the Bearings decision-hold regression: a terminal-looking but unreclaimed in-flight non-held task whose endpoint and worker are both verified absent must surface as a measured-liveness gate; held, active-worker, and live-blocked lanes must not receive that gate. Prove RED before GREEN and prove the property goes RED for the intended reason when the measured-liveness selector is neutralized. Keep the replacement tight, preserve production semantics, and do not absorb the oversized-fleet snapshot/argv work from the separately published PRs 1968 or 1964. Publish only through this repository's no-mistakes pipeline; do not force-push, merge, self-approve, or close PR 1735.
What Changed
Risk Assessment
✅ Low: The change is tightly scoped to Bearings liveness measurement, requires verified absence of both endpoint and worker, preserves held and active lanes, and includes RED-before-GREEN falsification coverage without absorbing unrelated fleet work.
Testing
The targeted lifecycle test passed and produced reviewer-visible CLI evidence. No UI surface applies.
Evidence: Bearings regression transcript
Focused regression passed; the transcript includes the measured-liveness gate, negative lanes, and selector-neutralization RED check.Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bin/fm-test-run.sh tests/fm-decision-hold-lifecycle.test.shVerified phantom, held, active-worker, selector-neutralization, and teardown-preservation cases.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.