feat(bin): support max Codex reasoning effort - #2008
Open
escidmore wants to merge 2 commits into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Update Firstmate Codex effort support so an explicit effort: "max" in config/crew-dispatch.json is accepted and forwarded to Codex as -c 'model_reasoning_effort="max"'. bin/fm-bootstrap.sh must accept max for Codex dispatch profiles; bin/fm-spawn.sh must emit the Codex model_reasoning_effort="max" setting when selected effort is max; the focused dispatch regression test must prove max is forwarded rather than omitted; update the authoritative configuration and harness-adapter documentation plus stale cross-references. Preserve existing behavior for Claude, Pi, OpenCode, and unsupported effort values. Do not broaden this task to OpenCode effort support, update Codex model support, or change quota behavior. Use the installed Codex CLI fact that model_reasoning_effort=max is accepted, without provider or model-specific fallback.
What Changed
effort: "max"for Codex dispatch profiles.model_reasoning_effort="max", with regression coverage proving it is not omitted.Risk Assessment
✅ Low: The narrow Codex-only change consistently updates validation, launch emission, regression coverage, and adapter documentation while preserving other harness behavior.
Testing
The focused spawn and bootstrap suites passed after clearing the runner’s BASH_ENV PATH shim. Manual evidence shows
codex/gpt-5/maxaccepted,effort=maxpersisted, and-c 'model_reasoning_effort="max"'emitted; the installed Codex CLI accepted the setting with exit 0. The worktree remained clean.Evidence: Codex max dispatch transcript
Evidence: Bootstrap max profile transcript
Evidence: Installed Codex CLI acceptance
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
BASH_ENV= rtk bash tests/fm-spawn-dispatch-profile.test.shBASH_ENV= rtk bash tests/fm-bootstrap.test.shBASH_ENV= rtk codex -c 'model_reasoning_effort="max"' --helpIsolatedfm-spawn.shdispatch with config-shaped Codex max profile and fake tmux captureIsolatedfm-bootstrap.shvalidation with verbose dispatch facts✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.