test: guard secondmate harness marker isolation - #2235
Open
4mb1t10n wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Implement #1243 exactly as specified: make tests/fm-secondmate-harness.test.sh hermetic against ambient harness markers so the suite behaves the same inside Claude Code, Pi, pi-signed, or Grok sessions. Keep the change test-only and exclude all product harness-resolution changes. Reproduce the ambient-marker failure and prove the corrected focused harness-resolution suite. Target main, fully close #1243 with a standalone , and preserve the existing harness semantics. Do not use a database or browser stack and never run local Cypress. Complete the No Mistakes pipeline plus exact-head CI and mergeability verification, but never merge.
What Changed
Risk Assessment
✅ Low: The test-only change adds an executable guard for all supported ambient harness markers, complements the existing top-level marker scrub, and does not alter product harness semantics.
Testing
Confirmed the nine-line test-only diff and exercised the executable focused harness-resolution behavior under ambient Claude, Pi, pi-signed, and Grok markers; every environment scrubbed its inherited marker and preserved existing fallback plus model/effort semantics, with reviewer-visible TAP transcripts captured and no worktree changes.
Evidence: Claude ambient-marker transcript
Evidence: Pi ambient-marker transcript
Evidence: pi-signed ambient-marker transcript
Evidence: Grok ambient-marker transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
Inspectedgit diff b5d430d6fdcd961ce9b681bf196f365c1825c284 4255fd852d1c384c2607c52f4959275b9d7e0366 -- tests/fm-secondmate-harness.test.shto confirm the change is test-only.Executed the focusedtest_ambient_harness_markers_are_scrubbed,test_harness_resolution, andtest_secondmate_model_effort_tokensfunctions underCLAUDECODE=1.Executed the same focused cases underPI_CODING_AGENT=true FM_PI_HARNESS=pi.Executed the same focused cases underPI_CODING_AGENT=true FM_PI_HARNESS=pi-signed.Executed the same focused cases underGROK_AGENT=1.Attempted a base-commit regression run and a longer target-suite run; concurrent lifecycle fixtures interfered with one another, so those transcripts were excluded from acceptance evidence and all related processes were stopped.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.