Skip to content

bugfix on touch devices, that caused preventing removing styles and m… #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ihtfw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix on touch devices, that caused preventing removing styles and m… #67

ihtfw wants to merge 1 commit into from

Conversation

@ihtfw
Copy link

@ihtfw ihtfw commented Nov 25, 2019

fixed problem that I've faced on touch devices

dhavald99
dhavald99 approved these changes Nov 26, 2019
View reviewed changes
Copy link

@dhavald99 dhavald99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me.
i had this error and that hungs page after drag and drop in touch devices
[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

@maddeezy
Copy link

maddeezy commented Dec 1, 2019

Agree...fixes problem I am experiencing on touch devices. The current issue is also present on the demo website for touch enabled devices.

@amit9033688351
Copy link

amit9033688351 commented Dec 2, 2019

i am agree. it fixed my issue.
@klaasman @johanneswilm
I have checked and its working fine in touch devices.

@vitorsei
Copy link

vitorsei commented Dec 9, 2019

Could you guys please merge this one?
It's such a simple change.

Thanks

@maddeezy
Copy link

maddeezy commented Dec 9, 2019

0.7 working fine on touch devices before this addition

@maddeezy maddeezy mentioned this pull request Dec 9, 2019
Open
@GabrielMahan
Copy link

GabrielMahan commented Dec 11, 2019

Can confirm that this fixes some issues we've been having.

@soyersoyer soyersoyer mentioned this pull request Dec 14, 2019
Open
@khellang
Copy link

khellang commented Mar 22, 2020

What are the chances of this landing at some point? 🤔

kenzotakahashi added a commit to kenzotakahashi/vue-smooth-dnd that referenced this pull request Apr 8, 2020
@kenzotakahashi
Use sdnd fork that fixes touch device bug
bd4a261 
kutlugsahin/smooth-dnd#67
@prileso prileso mentioned this pull request Sep 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhavald99 dhavald99 dhavald99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ihtfw @maddeezy @amit9033688351 @vitorsei @GabrielMahan @khellang @dhavald99