Skip to content

Conversation

@DocShotgun
Copy link

@DocShotgun DocShotgun commented Nov 19, 2025

What does this PR do?

Adds an arg to scripts/convert_cpu_weights.py named --resume-layer to allow resuming conversion on a specific layer - useful if conversion fails mid-run due to running out of memory despite enabling --no-merge-safetensor.

Before submitting

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @DocShotgun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CPU weight conversion script by adding a resume functionality. This improvement allows the conversion process to be restarted from a specific layer, significantly increasing the robustness and user-friendliness of the script, especially when dealing with large models or resource constraints that might cause interruptions.

Highlights

  • New Feature: Resume Conversion: Introduced a new command-line argument --resume-layer to scripts/convert_cpu_weights.py, enabling users to restart the weight conversion process from a specified layer index.
  • Improved Robustness: This feature is particularly useful for handling mid-run failures, such as out-of-memory errors during large model conversions, allowing for efficient recovery without re-processing already completed layers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a --resume-layer argument to allow resuming the weight conversion process from a specific layer. The implementation is straightforward and correct. My feedback focuses on improving the logging messages for better clarity and reducing verbosity, and on updating the documentation to reflect the new functionality. These changes will enhance the user experience and maintainability of the script.

# Process layers with memory cleanup
for i, (layer_idx, expert_ids) in enumerate(sorted(expert_layers.items())):
if layer_idx < resume_layer:
print(f"Skipping layer {layer_idx} (resume_layer={resume_layer})")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This print statement is executed for every skipped layer. If resuming from a high layer number (e.g., 100), this will produce 100 lines of logs, which can be noisy. Additionally, the resume_layer is already printed at the start, making it redundant here. Consider simplifying the message to reduce log verbosity. For a future improvement, you might consider printing a single summary message before the loop instead of logging each skipped layer.

                print(f"Skipping layer {layer_idx}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant