-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[feat]: kt-kernel: Add resume arg to CPU weight conversion #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @DocShotgun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the CPU weight conversion script by adding a resume functionality. This improvement allows the conversion process to be restarted from a specific layer, significantly increasing the robustness and user-friendliness of the script, especially when dealing with large models or resource constraints that might cause interruptions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a --resume-layer argument to allow resuming the weight conversion process from a specific layer. The implementation is straightforward and correct. My feedback focuses on improving the logging messages for better clarity and reducing verbosity, and on updating the documentation to reflect the new functionality. These changes will enhance the user experience and maintainability of the script.
| # Process layers with memory cleanup | ||
| for i, (layer_idx, expert_ids) in enumerate(sorted(expert_layers.items())): | ||
| if layer_idx < resume_layer: | ||
| print(f"Skipping layer {layer_idx} (resume_layer={resume_layer})") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This print statement is executed for every skipped layer. If resuming from a high layer number (e.g., 100), this will produce 100 lines of logs, which can be noisy. Additionally, the resume_layer is already printed at the start, making it redundant here. Consider simplifying the message to reduce log verbosity. For a future improvement, you might consider printing a single summary message before the loop instead of logging each skipped layer.
print(f"Skipping layer {layer_idx}")
What does this PR do?
Adds an arg to
scripts/convert_cpu_weights.pynamed--resume-layerto allow resuming conversion on a specific layer - useful if conversion fails mid-run due to running out of memory despite enabling--no-merge-safetensor.Before submitting