-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update README with Python 3.12 and dependency changes #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated Python version in installation instructions and adjusted KTransformers and flash-attention wheel filenames accordingly.
Summary of ChangesHello @JimmyPeilinLi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the installation instructions to use Python 3.12, which is a welcome change. However, the updated commands for installing ktransformers and flash-attention contain inconsistencies and errors that will likely cause the installation to fail for users. I've left specific comments on how to correct these issues to ensure the instructions are accurate and user-friendly.
|
|
||
| # 4. Install flash-attention, download the corresponding file based on your Python and Torch versions from: https://github.com/Dao-AILab/flash-attention/releases | ||
| pip install https://github.com/Dao-AILab/flash-attention/releases/download/v2.8.3/flash_attn-2.8.3+cu12torch2.8cxx11abiTRUE-cp310-cp310-linux_x86_64.whl | ||
| pip install flash_attn-2.8.3+cu12torch2.7cxx11abiTRUE-cp312-cp312-linux_x86_64.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The installation command for flash-attention is incomplete and appears to be incorrect.
- The command
pip install flash_attn-2.8.3...will fail unless the user has already downloaded the file. It would be more user-friendly to provide a full command to download and install, for example usingwgetor by providing a direct URL topip. - The filename itself seems wrong. The
flash-attentionproject does not appear to have av2.8.3release, andtorch2.7is not a standard PyTorch version.
Please verify the correct wheel and provide a complete, working installation command for users.
| # 3. Install the KTransformers wheel that matches your Torch and Python versions (Note: The CUDA version can differ from that in the wheel filename.) | ||
| pip install ktransformers-0.4.1+cu128torch28fancy-cp310-cp310-linux_x86_64.whl | ||
| # 3. Install the KTransformers wheel that matches your Torch and Python versions, from https://github.com/kvcache-ai/ktransformers/releases/tag/v0.4.1 (Note: The CUDA version can differ from that in the wheel filename.) | ||
| pip install ktransformers-0.4.1+cu128torch27fancy-cp312-cp312-linux_x86_64.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in the PyTorch version within the ktransformers wheel filename. The official release page for v0.4.1 provides a wheel with torch28 for Python 3.12, but the documentation here specifies torch27. To prevent installation errors, this should be corrected to match the actual released file.
| pip install ktransformers-0.4.1+cu128torch27fancy-cp312-cp312-linux_x86_64.whl | |
| pip install ktransformers-0.4.1+cu128torch28fancy-cp312-cp312-linux_x86_64.whl |
|
Could you follow the conventional rule for commit messages? |
Updated Python version in installation instructions and adjusted KTransformers and flash-attention wheel filenames accordingly.
What does this PR do?
Fixes # (issue)
Before submitting