Skip to content

Conversation

@JimmyPeilinLi
Copy link
Collaborator

Updated Python version in installation instructions and adjusted KTransformers and flash-attention wheel filenames accordingly.

What does this PR do?

Fixes # (issue)

Before submitting

Updated Python version in installation instructions and adjusted KTransformers and flash-attention wheel filenames accordingly.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JimmyPeilinLi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the README.md file to reflect compatibility with Python 3.12. It modifies the installation instructions to recommend Python 3.12 and adjusts the filenames for the KTransformers and Flash-Attention wheel dependencies to ensure they align with the new Python and Torch versions, providing accurate guidance for users setting up the environment.

Highlights

  • Python Version Update: The recommended Python version in the installation instructions has been updated from 3.10 to 3.12.
  • KTransformers Dependency: The pip install command for KTransformers has been adjusted to reference the wheel compatible with Python 3.12 and Torch 2.7.
  • Flash-Attention Dependency: The pip install command for Flash-Attention has been updated to use the wheel compatible with Python 3.12 and Torch 2.7.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the installation instructions to use Python 3.12, which is a welcome change. However, the updated commands for installing ktransformers and flash-attention contain inconsistencies and errors that will likely cause the installation to fail for users. I've left specific comments on how to correct these issues to ensure the instructions are accurate and user-friendly.


# 4. Install flash-attention, download the corresponding file based on your Python and Torch versions from: https://github.com/Dao-AILab/flash-attention/releases
pip install https://github.com/Dao-AILab/flash-attention/releases/download/v2.8.3/flash_attn-2.8.3+cu12torch2.8cxx11abiTRUE-cp310-cp310-linux_x86_64.whl
pip install flash_attn-2.8.3+cu12torch2.7cxx11abiTRUE-cp312-cp312-linux_x86_64.whl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The installation command for flash-attention is incomplete and appears to be incorrect.

  1. The command pip install flash_attn-2.8.3... will fail unless the user has already downloaded the file. It would be more user-friendly to provide a full command to download and install, for example using wget or by providing a direct URL to pip.
  2. The filename itself seems wrong. The flash-attention project does not appear to have a v2.8.3 release, and torch2.7 is not a standard PyTorch version.

Please verify the correct wheel and provide a complete, working installation command for users.

# 3. Install the KTransformers wheel that matches your Torch and Python versions (Note: The CUDA version can differ from that in the wheel filename.)
pip install ktransformers-0.4.1+cu128torch28fancy-cp310-cp310-linux_x86_64.whl
# 3. Install the KTransformers wheel that matches your Torch and Python versions, from https://github.com/kvcache-ai/ktransformers/releases/tag/v0.4.1 (Note: The CUDA version can differ from that in the wheel filename.)
pip install ktransformers-0.4.1+cu128torch27fancy-cp312-cp312-linux_x86_64.whl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There appears to be a typo in the PyTorch version within the ktransformers wheel filename. The official release page for v0.4.1 provides a wheel with torch28 for Python 3.12, but the documentation here specifies torch27. To prevent installation errors, this should be corrected to match the actual released file.

Suggested change
pip install ktransformers-0.4.1+cu128torch27fancy-cp312-cp312-linux_x86_64.whl
pip install ktransformers-0.4.1+cu128torch28fancy-cp312-cp312-linux_x86_64.whl

@KMSorSMS
Copy link
Collaborator

Could you follow the conventional rule for commit messages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants