Conversation
|
@kvesteri foremost: thanks for maintaining sqlalchemy-utils. We really enjoyed using it so far. Is there any way we can get this in? I would love to help if there is anything left to do |
|
I think that this whole part of sqlalchemy-utils needs some work (see #761) … and it seems that there is currently noone around to maintain this code properly (ie. with an opinion on its architecture). Having said that I had luck getting a bug fix in (#754) by also providing a test case that demonstrates the issue. |
|
We could add a small test for it if required. @tim-haselhoff wdyt? |
kurtmckee
left a comment
There was a problem hiding this comment.
There appear to be several unnecessary changes here; the only thing that appears necessary is to add:
@property
def python_type(self):
return ArrowPlease add a unit test to demonstrate that this is resolving a bug.
| @@ -1,3 +1,4 @@ | |||
| from arrow import Arrow | |||
There was a problem hiding this comment.
This results in an ImportError if arrow isn't installed; the current architecture is to allow for imports within the sqlalchemy_utils package but only raise an exception if a class is used but the underlying dependency isn't installed.
Fix sqlalchemy returning datetime in python instead of arrow when using arrow