chore(l1): bump glamsterdam fixtures to v6.1.1#6959
Conversation
|
🤖 Claude Code ReviewNo stale references to the old version remain — the bump is complete and consistent across all files. Review: PR 6959 — bump glamsterdam fixtures to v6.1.1This is a small, mechanical maintenance PR that bumps the pinned What it does:
Verification:
Notes:
Overall this looks like a clean, low-risk chore PR. No correctness, security, or performance concerns — nothing to change. Automated review by Claude (Anthropic) · sonnet · custom prompt |
🤖 Kimi Code ReviewThis PR performs a version bump for Amsterdam devnet fixtures (v6.1.0 → v6.1.1) and adds exception mapping for invalid chain ID transactions. The changes are mechanical, consistent, and correct. Review Summary:
No issues found. The PR correctly maintains the existing skip for stateless tests while updating live fixture references to v6.1.1. Automated review by Kimi (Moonshot AI) · kimi-k2.5 · custom prompt |
🤖 Codex Code ReviewNo findings. The fixture/version bumps are internally consistent across Hive and all EF-test entry points, and the new engine exception mapping at tooling/ef_tests/engine/src/exception_mapper.rs:41 matches the block-validation error wording emitted for wrong-chain-id transactions ( Residual risk: I could not run the targeted Automated review by OpenAI Codex · gpt-5.4 · custom prompt |
Greptile SummaryThis PR bumps the glamsterdam fixture suite from
Confidence Score: 5/5Routine fixture version bump with a small, targeted exception-mapper addition; no logic changes to the client itself. All changes are either URL/version-string updates, comment refreshes, or the single new INVALID_CHAINID substring entry in the exception mapper. The new mapping is consistent with the surrounding entries and is needed to avoid false negatives on chain-ID rejection tests introduced in the new fixture set. No application logic is altered. No files require special attention; exception_mapper.rs carries the only logic change and is straightforward.
|
| Filename | Overview |
|---|---|
| tooling/ef_tests/engine/src/exception_mapper.rs | Adds TransactionException.INVALID_CHAINID substring-match entry; change is minimal, correct, and consistent with the existing mapper style. |
| .github/config/hive/amsterdam.yaml | Bumps fixture URL from v6.1.0 to v6.1.1 and updates the EELS commit hash to match the new release. |
| tooling/ef_tests/blockchain/.fixtures_url_amsterdam | URL-only file bumped from v6.1.0 to v6.1.1; consistent with other fixture URL files. |
| tooling/ef_tests/engine/.fixtures_url_amsterdam | URL-only file bumped from v6.1.0 to v6.1.1; consistent with other fixture URL files. |
| tooling/ef_tests/state/.fixtures_url_amsterdam | URL-only file bumped from v6.1.0 to v6.1.1; consistent with other fixture URL files. |
| tooling/ef_tests/blockchain/tests/all.rs | Comment-only update; version references changed from v6.1.0 to v6.1.1. The fork_Amsterdam skip logic is unchanged. |
| docs/known_issues.md | Documentation updated to reflect v6.1.1; the zkevm bundle skip explanation remains accurate. |
| crates/vm/backends/levm/mod.rs | Comment-only change updating the spec version reference in a doc comment. |
| test/tests/levm/eip8038_tests.rs | Comment-only update; expected-values reference bumped from v6.1.0 to v6.1.1. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[EF Test Harness] --> B{Exception in fixture?}
B -- Yes --> C[exception_mapper::matches]
C --> D{Split on pipe}
D --> E[matches_canonical per alternative]
E --> F{Sub or Re?}
F -- Sub --> G["actual.contains(text)"]
F -- Re --> H["regex.is_match(actual)"]
G --> I{Hit?}
H --> I
I -- Yes --> J[Test passes]
I -- No --> K[Try next entry]
K --> E
K -- exhausted --> L[Test fails: unmatched exception]
subgraph "New in v6.1.1"
N["TransactionException.INVALID_CHAINID\n→ 'Transaction has invalid chain id'"]
end
N -.added.-> G
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[EF Test Harness] --> B{Exception in fixture?}
B -- Yes --> C[exception_mapper::matches]
C --> D{Split on pipe}
D --> E[matches_canonical per alternative]
E --> F{Sub or Re?}
F -- Sub --> G["actual.contains(text)"]
F -- Re --> H["regex.is_match(actual)"]
G --> I{Hit?}
H --> I
I -- Yes --> J[Test passes]
I -- No --> K[Try next entry]
K --> E
K -- exhausted --> L[Test fails: unmatched exception]
subgraph "New in v6.1.1"
N["TransactionException.INVALID_CHAINID\n→ 'Transaction has invalid chain id'"]
end
N -.added.-> G
Reviews (1): Last reviewed commit: "chore(ef-tests): bump glamsterdam-devnet..." | Re-trigger Greptile
Motivation
https://github.com/ethereum/execution-specs/releases/tag/tests-glamsterdam-devnet@v6.1.1 released
Description
Checklist
STORE_SCHEMA_VERSION(crates/storage/lib.rs) if the PR includes breaking changes to theStorerequiring a re-sync.Closes #issue_number