Skip to content

fix the bug pointed out from issue 41 by Yuri Govorushchenko #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
humorless wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix the bug pointed out from issue 41 by Yuri Govorushchenko #56

humorless wants to merge 1 commit into from

Conversation

@humorless
Copy link
Member

@humorless humorless commented Jan 14, 2026

Yuri Govorushchenko pointed out that the previous solution to issue 41 has a bug and little defect:

  • bug: This example from README unexpectedly resets all the other default :color-scheme values. So for example, insertions will not be highlighted anymore.
  • defect: Using using :lambdaisland.deep-diff2.printer-impl/deletion is also wired.

Therefore, this PR changes that:

  • fix the bug.
  • provide more friendly keyword like :lambdaisland.deep-diff2/deletion

@humorless humorless mentioned this pull request Jan 14, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joannecheng joannecheng

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@humorless @joannecheng