fix(core): strip message IDs from cache keys using model_copy #33915
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #33883
Chat model cache keys are generated by serializing messages via
dumps(messages). The optionalBaseMessage.idfield (a UUID used solely for tracing/threading) is included in this serialization, causing functionally identical messages to produce different cache keys. This results in repeated API calls, cache bloat, and degraded performance in production workloads (e.g., agents, RAG chains, long conversations).This change normalizes messages only for cache key generation by stripping the nonsemantic
idfield using Pydantic V2’smodel_copy(update={"id": None}). The normalization is applied in both synchronous and asynchronous cache paths (_generate_with_cache/_agenerate_with_cache) immediately beforedumps().