Skip to content

Conversation

@dumko2001
Copy link

Description:
While investigating #6447, I identified a shadowed variable definition and a gap in test coverage:

  1. Shadowed Variable: The stream_writer variable was defined in Pregel.astream (lines ~2838) but was immediately potentially shadowed/ignored by subsequent logic. This is a potential source of ambiguity in async context propagation. This PR removes the redundant definition.
  2. Missing Test Coverage: There were no existing tests explicitly verifying get_stream_writer() works correctly when used inside a ToolNode running async tools. I added libs/langgraph/tests/test_get_stream_writer_async.py to verify this behavior and prevent regressions.

Issue: Addresses #6447

Dependencies: None

@vercel
Copy link

vercel bot commented Nov 27, 2025

@dumko2001 is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant