fix(langgraph): remove shadowed stream_writer in astream and add async tests #6507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While investigating #6447, I identified a shadowed variable definition and a gap in test coverage:
stream_writervariable was defined inPregel.astream(lines ~2838) but was immediately potentially shadowed/ignored by subsequent logic. This is a potential source of ambiguity in async context propagation. This PR removes the redundant definition.get_stream_writer()works correctly when used inside aToolNoderunning async tools. I addedlibs/langgraph/tests/test_get_stream_writer_async.pyto verify this behavior and prevent regressions.Issue: Addresses #6447
Dependencies: None