fix(prebuilt): support generic type arguments for ToolRuntime injection #6509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dumko2001 is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
4 tasks
dumko2001
force-pushed
the
fix/tool-runtime-generic
branch
from
8abcea9 to
29f4d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where injection types (like
ToolRuntime) were not recognized byToolNodewhen used with generic type arguments (e.g.,ToolRuntime[MyContext]).Previously, the
_is_injectioncheck relied solely onisinstanceandissubclass, which fail fortyping._GenericAliasobjects. This update adds a check usingtyping.get_origin()to correctly identify the base class of generic types, ensuring the runtime is injected correctly even when type hints are present.Issue: Fixes #6465
Dependencies: None
Twitter handle: @SidharthRajmoh2