-
Notifications
You must be signed in to change notification settings - Fork 617
fix(tongyi): tools params not support empty description #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @yelloyu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial bug fix for the Tongyi LLM model, specifically addressing how it processes tool parameters. The change ensures that the system can robustly handle scenarios where a tool parameter might lack a description, preventing runtime errors and enhancing the overall stability and reliability of tool integration within the model. This improves the model's resilience to variations in tool definitions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a potential KeyError that could occur if a tool's parameter properties are missing a description. The change is a good improvement for robustness. I've added one suggestion to further refine the formatting of the generated description string to avoid a minor formatting issue.
| desc = p_val["description"] | ||
| desc = p_val.get("description") or "" | ||
| if "enum" in p_val: | ||
| desc += f"; Only accepts one of the following predefined options: [{', '.join(p_val['enum'])}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the change on the previous line correctly handles a missing description, this line can introduce a leading semicolon in the description string if the original description was empty (e.g., '; Only accepts...'). To improve the formatting, we can add the semicolon separator conditionally only when a description already exists.
| desc += f"; Only accepts one of the following predefined options: [{', '.join(p_val['enum'])}]" | |
| desc += ('; ' if desc else '') + f"Only accepts one of the following predefined options: [{', '.join(p_val['enum'])}]" |
|
Please bump the version in the mainifest and link related PR in the description. |
Related Issues or Context
This PR contains Changes to Non-Plugin
This PR contains Changes to Non-LLM Models Plugin
This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.5.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment
SaaS Environment