async rfd #961
Open
async rfd #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmoulton
force-pushed
the
async-rfd-no-thread
branch
from
376ab0a to
5d0a299
Compare
Collaborator
Author
|
This needs testing on linux and windows. Just checking that file dialogs in the widget gallery files example will be sufficient
|
jrmoulton
force-pushed
the
async-rfd-no-thread
branch
from
5d0a299 to
67014aa
Compare
jrmoulton
force-pushed
the
async-rfd-no-thread
branch
from
67014aa to
0846b2e
Compare
Contributor
|
Works for me on Linux, but I do get a lag spike / pause before the dialog appears, which differs from what I see on the main branch. |
Collaborator
Author
|
That's strange. I'll probably just mark this as draft and leave it then. According to the rfd docs, this is better for macOS, but as it works just fine. Thanks for testing |
Contributor
|
on Windows it work just as well as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that it is easier to run futures on the event loop I have moved the file dialogs to use the new
FutureSignal. Now file dialogs no longer need to spawn a thread