Repository navigation
fix(settings): keep settings panels within the modal on narrow windows - #777
Merged
Merged
Conversation
- Let the content column shrink (min-w-0) and wrap rows so fixed-width controls no longer overflow the modal and get clipped. - Cap fixed-width controls with max-w-full. - Window transparency card: shrinkable grid column for the glass mode select, no-wrap labels, wrap the preview above the controls when the card is too narrow. - Collapse the settings sidebar to icons below 640px.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On smaller windows the Settings modal clipped its content on the right edge. Most visible in Appearance → Window transparency (blur): the "Glass mode" select overflowed the card, the opacity sliders and values crowded the edge, and labels wrapped onto two lines. The same overflow affected rows with fixed-width controls in Capture, Integrations, Shortcuts and App.
Root cause: the content column had no
min-w-0, so it grew to the intrinsic width of fixed-width controls (w-52/w-64) and the modal'soverflow-hiddenclipped it.Changes
SettingsModal: content column can shrink (min-w-0), panel hides horizontal overflow.SettingsRow: rows wrap; the control drops below the label when there is no room (ml-auto max-w-full).max-w-full.auto_minmax(0,1fr)grid so the select shrinks/truncates, no-wrap labels, preview wraps above the controls when the card is narrow.SettingsSidebar: icon-only (withtitletooltip, label kept assr-only) below 640px, so the menu does not take a third of the modal.Testing
npm run buildpasses.