Repository navigation
ci: snap in its own release job, drop 32-bit Windows - #787
Merged
Merged
Conversation
The v4.19.2 release lost the AppImage because the Snap Store timed out while installing snapcraft, a step in the linux job that had no continue-on-error. The snap now runs as its own job with continue-on-error, a 30 minute timeout and three tries to install snapcraft, so a Snap Store outage never blocks Windows, macOS or the AppImage, nor marks the release run failed. Test-Build no longer installs snapcraft or gets the store credentials: build-linux only builds the AppImage.
Electron 45 no longer ships win32-ia32 builds, so the Electron bump fails on Windows with a 404 for electron-v45.2.3-win32-ia32.zip. The nsis installer now targets x64 only; its file name does not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two release-build fixes.
Snap in its own release job
The v4.19.2 release lost the AppImage: the Snap Store timed out while the
linuxjob installed snapcraft (Download snap "core24" ... EOF), and that step had nocontinue-on-error(only the snap publish step did).snapjob afterprepare, like Windows, macOS and the AppImage.continue-on-error: true, a 30 minute timeout and three tries to install snapcraft. A Snap Store outage no longer blocks the other platforms or marks the release run failed. A snap failure shows only on thesnapjob, so check it when releasing.linuxjob builds only the AppImage.SNAPCRAFT_STORE_CREDENTIALS, sincebuild-linuxonly builds the AppImage.Drop the 32-bit Windows installer
Electron 45 no longer publishes
win32-ia32builds, so the Dependabot bump to 45.2.3 fails on Windows with a 404 forelectron-v45.2.3-win32-ia32.zip. The nsis target is now x64 only. The installer name does not change (LaraDumps-Setup-<version>.exe), so the docs links and the Homebrew/post-release steps are unaffected.Test plan
prepare,windows,mac,linux,snap.