Add template support to Reconstructor#1613
Open
Iluvatar wants to merge 1 commit into
Open
Conversation
Trees generated by the parser don't retain template information in their token names, so Reconstructor was trying to match the tree using the non-templated name, which caused an error. Add the full template name from the children matched by the tree matcher as a meta attribute for the given child so it can be read when recursing into that child.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trees generated by the parser don't retain template information in their token names, so Reconstructor was trying to match the tree using the non-templated name, which caused an error.
Add the full template name from the children matched by the tree matcher as a meta attribute for the given child so it can be read when recursing into that child.
This fixes #1500