Skip to content

docs: update mail skill guidance#1893

Open
infeng wants to merge 2 commits into
larksuite:mainfrom
infeng:feat/6fbc4d9
Open

docs: update mail skill guidance#1893
infeng wants to merge 2 commits into
larksuite:mainfrom
infeng:feat/6fbc4d9

Conversation

@infeng

@infeng infeng commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Updates the mail skill documentation for newer mailbox workflows.

  • Adds guidance for user-level allow and blocked sender lists.
  • Points message organization and trash operations to the higher-level shortcuts.
  • Documents mail HTML style guidance and linting behavior for compose flows.

Summary by CodeRabbit

  • Documentation
    • Added guidance for per-user allowed/blocked sender lists, including conflict behavior and explicit confirmation gating for list edits (with batch preview showing affected counts).
    • Updated mailbox workflow examples to use clearer shortcuts, including soft-delete via +message-trash and refined “整理” ordering for common actions.
    • Expanded HTML composition rules: no manual raw EML, documented write-path linting/auto-fixes, and how to inspect lint details with --show-lint-details / +lint-html.
    • Clarified native API usage when no shortcut applies, and expanded mail API/permission documentation for sender-list operations.

@github-actions github-actions Bot added domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact labels Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Mail documentation adds user-level sender-list guidance, refined mailbox workflows and shortcuts, expanded HTML linting rules, and detailed API resource and permission references.

Changes

Mail guidance and API documentation

Layer / File(s) Summary
Sender-list contracts and API coverage
skill-template/domains/mail.md, skills/lark-mail/SKILL.md
Documents mutually exclusive user-level allow/blocked sender lists, confirmation requirements, API methods, and required scopes.
Mailbox workflows and shortcuts
skill-template/domains/mail.md, skills/lark-mail/SKILL.md
Updates confirmed deletion, mailbox organization steps, shortcut usage, and native API guidance.
HTML authoring and linting
skill-template/domains/mail.md, skills/lark-mail/SKILL.md
Prohibits manually constructed raw EML and documents write-path linting, auto-fixes, lint details, and the read-only +lint-html shortcut.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • larksuite/cli#749: Covers related confirmation gating and affected-count requirements for mail write operations.
  • larksuite/cli#1885: Adds related allow/blocked sender command schemas and dry-run coverage.

Suggested reviewers: chanthuang, calendar-assistant

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main docs update to mail skill guidance.
Description check ✅ Passed It includes a summary and main change bullets, and the missing Test Plan/Related Issues sections are minor for this docs-only update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch feat/6fbc4d9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-mail/SKILL.md`:
- Line 69: Update the shared authorization rule so every operation marked “✅ 必须”
always requires confirmation and cannot be bypassed by stating the target and
action in the latest turn. Preserve confirmation gating for
allow_senders.batch_create/batch_remove and
blocked_senders.batch_create/batch_remove in skills/lark-mail/SKILL.md:69-69,
and mirror the same clarification in skill-template/domains/mail.md:55-55.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b8f28c81-2020-405d-8574-08c186f71b97

📥 Commits

Reviewing files that changed from the base of the PR and between 8acd55e and 735a22c.

📒 Files selected for processing (2)
  • skill-template/domains/mail.md
  • skills/lark-mail/SKILL.md

Comment thread skills/lark-mail/SKILL.md Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
skills/lark-mail/SKILL.md (1)

86-86: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add +message-modify and +message-trash to the Shortcuts table. They’re referenced in the workflow text, but the shortcut index doesn’t list them, so users can’t find the preferred commands from one place.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/lark-mail/SKILL.md` at line 86, Add +message-modify and +message-trash
to the Shortcuts table in SKILL.md, preserving the existing table format and
documenting both commands alongside the other preferred shortcuts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@skills/lark-mail/SKILL.md`:
- Line 86: Add +message-modify and +message-trash to the Shortcuts table in
SKILL.md, preserving the existing table format and documenting both commands
alongside the other preferred shortcuts.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c4b4748-36fb-49c5-97cf-58fdfa7f714b

📥 Commits

Reviewing files that changed from the base of the PR and between 735a22c and 436e18f.

📒 Files selected for processing (2)
  • skill-template/domains/mail.md
  • skills/lark-mail/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skill-template/domains/mail.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant