ci: split release-please into independent release and PR creation steps#117
Closed
ci: split release-please into independent release and PR creation steps#117
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Closing: The split release-please pattern is only needed for repos with artifact uploads. This attestation-only repo doesn't need it. The attestation changes are in PR #116. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the single
release-please-actioncall into two independent passes to support GitHub's immutable releases:skip-github-pull-request: true): Creates the GitHub release only. If a release is created, the workflow checks out the repo and pushes the tag manually (with idempotent "already exists" guard).skip-github-release: true): Runs only when no release was created, and handles PR creation/updates.This ensures the tag exists before release-please evaluates whether a release PR is still needed. Without this split, release-please could create a duplicate release PR because the tag wasn't present when it checked.
Matches the pattern established in ld-relay PR #622.
Review & Testing Checklist for Human
release_created(singular) vsreleases_created(plural) usage is correct — the inline tag-creation conditions use singular, while the job-level output consumed by downstreamciandpublishjobs uses plural. Both are valid release-please outputs but confirm they behave as expected for this repo.release_created != 'true') correctly makes the two passes mutually exclusive — releases OR PRs, never both in the same run.git config+git tag+git pushflow works correctly under theactions/checkout@v4default settings (shallow clone, detached HEAD, etc.).Notes
16a9c90856f42705d54a6fda1823352bdc62cf38is unchanged; only the version comment was updated from# v4to# v4.4.0for clarity.ci,publish) — they continue to gate onreleases_createdfrom the job outputs.Link to Devin session: https://app.devin.ai/sessions/7d5bda4d9dbe4ae0b950b30a50485e60
Requested by: @keelerm84
Note
Medium Risk
Moderate risk because it changes the release workflow’s control flow and gating conditions for downstream
ci/publish, which could affect whether releases are tagged/published correctly.Overview
Splits the
release-pleaseworkflow into two mutually exclusiverelease-please-actionruns: one that only creates GitHub releases (skip-github-pull-request) and another that only opens/updates release PRs (skip-github-release) when no release was created.When a release is created, the workflow now checks out the repo and creates/pushes the release tag manually with an idempotent “tag already exists” guard, and downstream
ci/publishjobs are gated on the singularrelease_createdoutput.Reviewed by Cursor Bugbot for commit c1b16ef. Bugbot is set up for automated code reviews on this repo. Configure here.