feat(components): add optional hideLabels and variant props to Switch#1917
Open
maheskett wants to merge 2 commits into
Open
feat(components): add optional hideLabels and variant props to Switch#1917maheskett wants to merge 2 commits into
maheskett wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 2a8748e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor change to the
Switchcomponent to add an optionalhideLabelsprop to hide On/Off text, and an optionalvariantprop with aprimaryoption for a blue selected state.Screenshots (if appropriate):
Note
Low Risk
Optional UI props with default behavior unchanged; no auth, data, or breaking API changes.
Overview
Switchgains two optional presentation props while keeping default behavior unchanged.hideLabelssuppresses the built-in On/Off text and applies a narrower compact track; selected-state handle motion is adjusted for the smaller width.variant="primary"styles the selected track with the interactive primary (blue) tokens instead of the default green.Styling is wired through CVA on
switchStyles;SwitchVariantsis exported from the package. Tests, Storybook stories, and a minor changeset cover the new API.Reviewed by Cursor Bugbot for commit 2a8748e. Bugbot is set up for automated code reviews on this repo. Configure here.