Skip to content

A project's own site takes the root - #1799

Merged
lbedner merged 1 commit into
mainfrom
site-root
Oct 22, 2026
Merged

lbedner merged 1 commit into
mainfrom
site-root

Conversation

@lbedner

@lbedner lbedner commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

A generated stack with a public site of its own (the rose stack's journal) had to edit main.py, a framework file, to mount its routes, and could not take / because the framework's landing held it and the shell's tests assumed it.

  • When app/components/web_frontend/routes/site.py exists, main.py mounts its router last, outside the Overseer's gate, and routes/pages.py registers its landing only when it does not: / is the site's, and no route of the site's can stand in front of a framework route (/login, /logout, /overseer and the rest keep working whatever the site declares).
  • The shell's own tests (toasts, htmx config, the mounted dialogs, the theme head and toggle, the base layout's head details) fetch a page of the shell through tests/shell.py's shell_path() and the shell fixture: the landing, or the Overseer's door where a site owns the root. The landing's own tests skip where there is no landing. They tested base.html, never the landing itself.
  • A guard in the framework's own tests holds the order and the condition. Docs: templates-and-partials.md. Dual-written into the live my-app.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 02:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

…site mounts last; the shell's tests fetch a shell page, not the root
@lbedner
lbedner merged commit 77d14a7 into main Oct 22, 2026
48 checks passed
@lbedner
lbedner deleted the site-root branch October 22, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants