Repository navigation
Conversation
…site mounts last; the shell's tests fetch a shell page, not the root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generated stack with a public site of its own (the rose stack's journal) had to edit
main.py, a framework file, to mount its routes, and could not take/because the framework's landing held it and the shell's tests assumed it.app/components/web_frontend/routes/site.pyexists,main.pymounts its router last, outside the Overseer's gate, androutes/pages.pyregisters its landing only when it does not:/is the site's, and no route of the site's can stand in front of a framework route (/login,/logout,/overseerand the rest keep working whatever the site declares).tests/shell.py'sshell_path()and theshellfixture: the landing, or the Overseer's door where a site owns the root. The landing's own tests skip where there is no landing. They testedbase.html, never the landing itself.templates-and-partials.md. Dual-written into the live my-app.