Skip to content

Illiana's card follows what she names; calls keep their cards steady - #1820

Merged
lbedner merged 1 commit into
mainfrom
on30-narrated
Oct 25, 2026
Merged

lbedner merged 1 commit into
mainfrom
on30-narrated

Conversation

@lbedner

@lbedner lbedner commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Closes #1803 (ON-30).

What

The path card follows what Illiana names. In a typed answer, hover or tap a part's name and the card lights that part and its lines. On a call, the card lights the part she names as you hear it (timed by the audio playhead, not the text stream). An answer heard again with Listen lights as it plays. Matching is by name (mentions.js), so a part the card does not draw is never lit.

Calls

  • A card stays up through the thread reload each saved turn makes: its loader keeps the card already drawn (hx-preserve, by drawn_id) instead of drawing it again mid-sentence.
  • A chart drawn again for one answer takes the first one's place.
  • A card stays with its own turn: TurnLog.drawn is the call's, so a silent turn no longer moves the next card onto the following answer.
  • Her steps show under her name as they run; lighting continues after the turn is saved.
  • end_call is only for a goodbye, never a turn with no words in it.
  • The shared call instructions say to draw in the same script as the lookup, before speaking.

Cards

  • draw_card refuses a card with no rows, and a chart whose every value is 0 (each kind's schema, compare included).
  • Bar charts measure from zero (charts.js fromZero).

What she can read

Also

  • Model picker: All, Text and Voice filters, with voice models under their vendor (ported from Steward).
  • A job's wiring card draws the lines of the part that runs it.
  • The staged code path folds repeated hops and skips registry fan-out.
  • The scheduler's next run is read as UTC.
  • The Stripe webhook listener dies with the server (PR_SET_PDEATHSIG) instead of being orphaned on reload.

Tests

New or changed tests cover each item above: tests/js/mentions.test.js, card and call tests, system tools, runtime, charts, queue status and dry path. Gates: tests/core and test_saved_settings pass.

Copilot AI balanced review requested due to automatic review settings October 25, 2026 01:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@illiana-review

Copy link
Copy Markdown

Illiana's review of d3888c4

Clear. Nothing new here holds the change.

Nothing new against any rule I hold. This has my seal of approval.

What this change touches
  • Parts: component:backend, component:scheduler, component:worker, service:ai, service:ai.chat, service:payment, shared:system
  • Depended on by: service:documents, service:finance, service:meetings
  • In no part: 34 files

The path card lights the part Illiana names: hover or tap a part in a
typed answer, follow her speech on a call by the audio playhead, and
again as an answer is heard back. Closes #1803.

Calls: a card stays up through the thread reload each saved turn makes
(hx-preserve), a redraw takes the first card's place, a card stays with
its own turn, and she ends a call only on a goodbye. Cards: no empty or
all-zero card is drawn, and bars measure from zero. She reads each
part's containers (memory against its limit, CPU) and each queue's
tasks. The model picker filters by All, Text or Voice, with voice models
under their vendor. Fixes: a job's wiring is its part's, the
scheduler's next run is UTC, and the Stripe listener dies with the
server.
@lbedner
lbedner merged commit d6cb89a into main Oct 25, 2026
48 checks passed
@lbedner
lbedner deleted the on30-narrated branch October 25, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ON-30: The path card follows Illiana as she explains it

2 participants