Conversation
Remove the `expandStringOperand` function and `evaluateExpression` calls. Expressions are now kept in their raw form (strings or objects) and only evaluated on the client side. This simplifies the server logic and allows the client to handle type resolution in its own context. Update type annotations to use `Expression | Literal` where applicable.
…v into ag/554-expr-literals
Fix expression handling for literals vs. instance names
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This includes:
Related Issue(s)
See #554 and #564.
Testing
UI logic looks good on https://staging.ctrl-flow.lbl.gov
End-to-end tests have also been performed by creating the SOO document with the following system options.
AHU
Cooling-only box
✅ The staging branch produces the same document as the main branch.