Skip to content

Conversation

@rtibbles
Copy link
Member

Summary

  • Adds the VCR library for testing
  • Monkey patches to fix an extant issue in the library when kwargs are passed to the urllib3 response read method
  • Moves all test requires specification into setup.py for ease of installation
  • Turns the VCR use_cassette decorator instead into a pytest.mark.skip if vcr is unavailable (we can't install it on Python 3.9 as it requires an incompatible version of urllib3 there)

References

This will allow us to test that #573 doesn't break Youtube downloading
Also will allow for testing of future GDrive integration

Reviewer guidance

Is this adequately documented?
Are tests passing?

Disable for Python 3.9 due to urllib3 version issues.
@rtibbles rtibbles mentioned this pull request Feb 20, 2025
@rtibbles rtibbles merged commit 6c8bf2b into learningequality:develop Feb 20, 2025
17 checks passed
@rtibbles rtibbles deleted the vcr branch February 20, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants