don't treat dataclasses with decoding fns as dataclasses, fixes #266#267
Open
dlwh wants to merge 1 commit intolebrice:masterfrom
Open
don't treat dataclasses with decoding fns as dataclasses, fixes #266#267dlwh wants to merge 1 commit intolebrice:masterfrom
dlwh wants to merge 1 commit intolebrice:masterfrom
Conversation
lebrice
requested changes
Jun 22, 2023
Owner
lebrice
left a comment
lebrice
left a comment
There was a problem hiding this comment.
Sorry I dont quite understand the issue atm. I'll give a proper review once I do.
For now though, the walrus operator is too recent to be included, sadly.
| field_dataclass = utils.get_dataclass_type_arg(field_type) | ||
| # See if it's a generic with a dataclass arg | ||
| # if so, extract the dataclass type from the annotation of the field. | ||
| elif (field_dataclass := utils.get_dataclass_type_arg(field_type)) is not None and\ |
Owner
There was a problem hiding this comment.
Can't use the walrus operator unfortunately, we want python 3.7+ support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.