Making add_help optional for parse and parse_known_args functions#360
Merged
lebrice merged 1 commit intolebrice:masterfrom Jan 20, 2026
Merged
Making add_help optional for parse and parse_known_args functions#360lebrice merged 1 commit intolebrice:masterfrom
lebrice merged 1 commit intolebrice:masterfrom
Conversation
Contributor
Author
|
cc @lebrice: deciding on this fix should be very quick whenever you have the time. |
Owner
|
Hey @farzad-elastix , thanks a lot! I'll take a look. |
lebrice
approved these changes
Jan 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 34 34
Lines 4554 4554
=======================================
Hits 3930 3930
Misses 624 624 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is very limited in scope. It's probably easier to just read the 4 LoC changed. The default is the right one most of the time but I've run into an issue where I need to handle the CLI args in multiple steps and that means I'll have to disable help in the first stages until I get to the final stage.
The changes are non-destructive and do not change the default behavior.
I'll take the opportunity to say my thank for the repo. I love the simplicity and how it promotes better coding practices over the original
argparse. I've run into the rough edges (e.g. handling nested items or dictionaries), but still recommend it.