Open
Conversation
0-Yorick-0
force-pushed
the
create-xdebug-debugger-plugin
branch
from
291001c to
8dfe0c9
Compare
Member
|
Hi @0-Yorick-0 |
bonidier
reviewed
Dec 6, 2021
Member
bonidier
left a comment
bonidier
left a comment
There was a problem hiding this comment.
looks useful, just fix review and apply a shellcheck pass on the plugin
| local dc_xdebug_env_value | ||
|
|
||
| if [[ -f "${origin_xdebug_config_file}" ]]; then | ||
| target_xdebug_config=".led/90-xdebug-config.ini" |
Member
There was a problem hiding this comment.
you must create .led directory if missing, otherwise the sed command can't create output file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Procédure de Test :
led upled php xdebug -eled php xdebug -d