Skip to content

add "include_vetoes" kwarg to calibrate_all - #49

Merged
theHenks merged 2 commits into
mainfrom
skip_vetos
Aug 26, 2026
Merged

theHenks merged 2 commits into
mainfrom
skip_vetos

Conversation

@DaGeibl

@DaGeibl DaGeibl commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR adds a new keyword argument, include_vetoes, to calibrate_all.

With this option, users can choose whether the veto systems (PMTs and SiPMs) are also calibrated and included in the output event files.

I found this useful when I was working only with the germanium detectors and wanted to create the event tier, without caring about the other subsystems and making sure that they have the necessary data to calibrate them.

@codecov

codecov Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 108 lines in your changes missing coverage. Please review.
✅ Project coverage is 5.30%. Comparing base (6efd71d) to head (b3835c8).

Files with missing lines Patch % Lines
src/calibrate_all.jl 0.00% 108 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #49      +/-   ##
========================================
- Coverage   5.77%   5.30%   -0.47%     
========================================
  Files          7       7              
  Lines        329     358      +29     
========================================
  Hits          19      19              
- Misses       310     339      +29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theHenks theHenks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to make the whole event building configurable with a kwarg (s. suggestion)

Comment thread src/calibrate_all.jl Outdated
…sybols) decides which sybsystem are included in the event tier generation

@theHenks theHenks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would check type stability once with all the new nothing assignments.

@theHenks

Copy link
Copy Markdown
Collaborator

I would check type stability once with all the new nothing assignments.

I checked this. The nothing assignments are harmless (two-element unions).
The only real loss are the cross_systems_cols which are abstract now an abstract NamedTuple

@theHenks
theHenks merged commit e52705e into main Aug 26, 2026
8 of 10 checks passed
@theHenks
theHenks deleted the skip_vetos branch August 26, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants