add "include_vetoes" kwarg to calibrate_all - #49
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
========================================
- Coverage 5.77% 5.30% -0.47%
========================================
Files 7 7
Lines 329 358 +29
========================================
Hits 19 19
- Misses 310 339 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
theHenks
requested changes
Aug 13, 2026
theHenks
left a comment
Collaborator
There was a problem hiding this comment.
I propose to make the whole event building configurable with a kwarg (s. suggestion)
…sybols) decides which sybsystem are included in the event tier generation
theHenks
requested changes
Aug 25, 2026
theHenks
left a comment
Collaborator
There was a problem hiding this comment.
I would check type stability once with all the new nothing assignments.
Collaborator
I checked this. The nothing assignments are harmless (two-element unions). |
theHenks
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new keyword argument, include_vetoes, to calibrate_all.
With this option, users can choose whether the veto systems (PMTs and SiPMs) are also calibrated and included in the output event files.
I found this useful when I was working only with the germanium detectors and wanted to create the event tier, without caring about the other subsystems and making sure that they have the necessary data to calibrate them.