Skip to content

Cast item lists to common schema when converting to Arrow - #1167

Merged
mdekstrand merged 2 commits into
lenskit:mainfrom
mdekstrand:fix/1164-null-columns
Jul 30, 2026
Merged

Cast item lists to common schema when converting to Arrow#1167
mdekstrand merged 2 commits into
lenskit:mainfrom
mdekstrand:fix/1164-null-columns

Conversation

@mdekstrand

Copy link
Copy Markdown
Member

If item lists in a collection have different schemas, they would fail when being converted to Arrow. This change adds a test for the bug this causes, and an explicit cast to convert data to a common schema.

Closes #1164.

@mdekstrand mdekstrand added this to the 2026.3 milestone Jul 30, 2026
@mdekstrand mdekstrand self-assigned this Jul 30, 2026
@mdekstrand mdekstrand added the data Data management support. label Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.61%. Comparing base (58f7ef0) to head (5815b92).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1167   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files         261      261           
  Lines       17328    17329    +1     
=======================================
+ Hits        15529    15530    +1     
  Misses       1799     1799           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand
mdekstrand merged commit 5815b92 into lenskit:main Jul 30, 2026
42 checks passed
@mdekstrand
mdekstrand deleted the fix/1164-null-columns branch July 30, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Data management support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Item lists with null columns cannot correctly convert to Arrow tables for serialization

1 participant