Remove dashmap usage #4408
Open
Remove dashmap usage #4408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbj
reviewed
Oct 27, 2025
| use std::path::Path; | ||
| #[cfg(feature = "default")] | ||
| use std::sync::LazyLock; | ||
| #[cfg(feature = "default")] |
Collaborator
There was a problem hiding this comment.
this is causing cargo check --no-default-features to fail, because all of these imports are used with or without default features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm the dashmap author and recently while working on a leptos project, I discovered dashmap in the deptree and got curious as to why it was there. Upon inspecting the usage of it in leptos, I've arrived the the conclusion that it's not appropriate in any of the places it's used.
The reason for this in all cases is that generally, you need to have very significant contention on the map across multiple cores for it to be worth it at all, after observing it's usage in the wild across a few years I like to say that most people that use it probably shouldn't. Dashmap is a very specialized tool and due to internal overheads necessary for a concurrent datastructure, it's generally doesn't provide any performance benefit (usually the opposite) unless you're hammering it with 1M+ lookups per second across cores, which is exceedingly unlikely in the places it's used.
Therefore, I've removed every usage of it across leptos that I found so far, and replaced them with the far simpler
Mutex<HashMap>orRwLock<HashMap>depending on the spot.