lime-proto-batadv change MAC also of wlan interfaces

[ilario]

In order to avoid the "received packet on bat0 with own address as source address" annoying (but harmless) message we are customizing the MAC address of the ethernet VLAN interface, see #726 (and #703 and #724).
But in some cases (see here) for some reason the wireless VLAN interface can be taken as MainIF by batman-adv and therefore needs to have a customized mac address also.

This PR simply moves the MAC customization code out of the if block, with no further edit.

[codecov-io]

Codecov Report

Merging #820 (99112c5) into master (332528d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   72.27%   72.27%           
=======================================
  Files          37       37           
  Lines        3293     3293           
=======================================
  Hits         2380     2380           
  Misses        913      913           

Impacted Files	Coverage Δ
...oto-batadv/files/usr/lib/lua/lime/proto/batadv.lua	96.66% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 332528d...99112c5. Read the comment docs.

[G10h4ck]

The change looks good, did you tested it on a few different devices/architectures, every-time a mac is changed it could tickle up some unexpected bug even in the hardware driver :-\

[ilario]

I quickly checked on YouHua WR1200JS and TP-Link WDR3600, please help with the testing as I will not have time to test further or on other routers. @G10h4ck @spiccinini

[G10h4ck]

I quickly checked on YouHua WR1200JS and TP-Link WDR3600, please help with the testing as I will not have time to test further or on other routers. @G10h4ck @spiccinini

ok that seems enough as those devices have quite different wifi stack

[spiccinini]

This won't change the mac address seen by the other wireless stations right? sothe ipv6 link local addresses of the wireless interfaces won't change? Sorry if this seems a silly question

[G10h4ck]

This won't change the mac address seen by the other wireless stations right? sothe ipv6 link local addresses of the wireless interfaces won't change? Sorry if this seems a silly question

I expect the macaddress of the wlanX-mesh interface so the one seen as station from the others and it's relative link local ipv6 address should not change. Instead I expect all of those properties change for the vlan interface. So just to make it explicit I expect wlanX-mesh_123 to get a different mac address and a different IPv6 link local address. Do we assume wlanX-mesh and wlanX-mesh_123 have same properties in some part of the stack?

[spiccinini]

This won't change the mac address seen by the other wireless stations right? sothe ipv6 link local addresses of the wireless interfaces won't change? Sorry if this seems a silly question

I expect the macaddress of the wlanX-mesh interface so the one seen as station from the others and it's relative link local ipv6 address should not change. Instead I expect all of those properties change for the vlan interface. So just to make it explicit I expect wlanX-mesh_123 to get a different mac address and a different IPv6 link local address.

Thanks Gio!

Do we assume wlanX-mesh and wlanX-mesh_123 have same properties in some part of the stack?

Not that I am aware.