Add FroidurePin bindings + FroidurePin Transf tests#69
Merged
Conversation
Add containment (Base.in, position, sorted_position, to_sorted_position),
modification (Base.push!, closure!, copy_closure, copy_add_generators),
settings (batch_size, set_batch_size!), predicates (contains_one,
is_idempotent), and index queries (prefix, suffix, first_letter,
final_letter, fast_product, number_of_rules, number_of_idempotents)
to the FroidurePin{E} high-level wrapper.
Add high-level Julia wrappers for the remaining FroidurePin methods: - rules/current_rules (Pair-based), normal_forms/current_normal_forms - idempotents, sorted_elements (with _copy_cxx_element for StdVector safety) - minimal_factorisation, current_minimal_factorisation, factorisation - position(fp, word), right/left_cayley_graph, to_element, equal_to
Add Julia-level wrappers for C++-bound methods that were missed: - product_by_reduction: product via Cayley graph indices - position_of_generator: position of i-th generator - current_length / word_length: factorisation length - currently_contains_one: no-enumeration identity check - current_number_of_rules: no-enumeration rule count - current_max_word_length: no-enumeration max word length - number_of_elements_of_length: count by exact/range length
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage ? 75.85%
=======================================
Files ? 15
Lines ? 1114
Branches ? 0
=======================================
Hits ? 845
Misses ? 269
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@james-d-mitchell I'm going to go ahead and merge this for now since I think it's in pretty good shape. I spent a lot of time on the docs and they are very comprehensive, so I think that's probably the easiest way for you to review the changes. Quite happy with how this one turned out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR binds FroidurePinBase and FroidurePin, exposing a Julia FroidurePin{E} type which supports Transf, Perm, PPerm, and BMat8.
Currently only the test-froidure-pin-transf.cpp tests from libsemigroups have been ported, with other tests such as bmat8 to be ported in later PRs.