Skip to content

fix(dom): remove backface visibility which causes a crash on Sky #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiefcll merged 15 commits into from
May 8, 2026
Merged

fix(dom): remove backface visibility which causes a crash on Sky #85

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fc9beca
fix: update node styles to support white-space wrapping
pecoram Apr 27, 2026
9333be0
fix: improve image loading handling with opacity transition
pecoram Apr 27, 2026
d55dc79
fix: enhance image loading handling with background layer visibility
pecoram Apr 27, 2026
64c105d
Merge remote-tracking branch 'upstream' into patch
pecoram Apr 30, 2026
d6f8689
fix(dom): enhance node styles with perspective and backface visibility
pecoram May 5, 2026
86b59c3
fix(dom): optimize transform updates and reduce redundant style writes
pecoram May 6, 2026
1b7ad88
fix: removed comment
pecoram May 6, 2026
d66d845
doc: added comments
pecoram May 6, 2026
2a56de1
fix(dom): removed imgBg if not needed
pecoram May 6, 2026
cbdcace
fix(dom): include radiusStyle in background layer condition
pecoram May 6, 2026
a38e78d
fix(dom): include bgStyle in background layer condition check
pecoram May 6, 2026
8ab51f0
fix(dom): simplify transform and backface visibility handling
pecoram May 6, 2026
325a16e
fix(dom): remove backface visibility handling and update background l…
pecoram May 7, 2026
c65e1fb
Merge remote-tracking branch 'upstream' into patch
pecoram May 7, 2026
7f0c700
fix(dom): remove backface visibility from node styles update
pecoram May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/dom-renderer/domRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,8 @@ function updateTransformOnly(node: DOMNode | DOMText): void {

if (transform.length > 0) {
s.transform = `${transform}`;
s.backfaceVisibility = 'hidden';
} else {
s.transform = '';
s.backfaceVisibility = '';
}

updateRenderStateIfNeeded(node);
Expand Down Expand Up @@ -318,8 +316,6 @@ function updateNodeStyles(node: DOMNode | DOMText) {
const transform = buildTransformCSS(props);
if (transform.length > 0) {
style += `transform: ${transform};`;
style += `backface-visibility: hidden;`;
style += `-webkit-backface-visibility: hidden;`;
}
}

Expand Down Expand Up @@ -684,7 +680,7 @@ function updateNodeStyles(node: DOMNode | DOMText) {
}

let bgLayerStyle =
'position: absolute; top:0; left:0; right:0; bottom:0; z-index: -1; pointer-events: none; overflow: hidden;';
'position: absolute; top:0; left:0; right:0; bottom:0; z-index: -1; pointer-events: none; -webkit-clip-path: inset(0); clip-path: inset(0);';
if (bgStyle) {
bgLayerStyle += bgStyle;
}
Expand Down
Loading