Switch from reqwest to bitreq
#737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`reqwest` is one of the largest contributors of code size and dependencies (including single-author dependencies) to much of the rust-bitcoin ecosystem, including ldk-node. Thus, Tobin took the time to (ask an LLM to) fork `minreq` and add async support to it, including async `rustls` support. As its now a functional HTTP(s) client, its time for the ecosystem to start switching over. Luckily, its ~trivial to do.
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Jan 1, 2026
Collaborator
There was a problem hiding this comment.
This needs a formatter run, otherwise generally LGTM.
Should be okay for RGS/scorer downloads, but for other applications (syncing, mostly) I think we want to wait switching over until bitreq is properly async and they have a way to reuse a single connection instead of reopening one per request (see rust-bitcoin/corepc#441 and rust-bitcoin/corepc#442).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwestis one of the largest contributors of code size and dependencies (including single-author dependencies) to much of the rust-bitcoin ecosystem, including ldk-node.Thus, Tobin took the time to (ask an LLM to) fork
minreqand add async support to it, including asyncrustlssupport. As its now a functional HTTP(s) client, its time for the ecosystem to start switching over. Luckily, its ~trivial to do.