Fix flaky watchtower and invoice tests

[gijswijs]

Description

This PR addresses intermittent test failures in the watchtower client and invoice test suites.

Changes

Two test scenarios had race conditions causing flaky failures:

testRemoveLockedAddr: Added synchronization via a dialStarted channel to ensure the dial has begun before asserting that an address is locked. Previously, the test could check the lock state before session negotiation started.

testTowerSwitch: Wrapped RemoveTower in wait.Predicate since the address may still be locked by an active session, causing intermittent failures.

Finally, the test timeout for invoices from is increased from 10s to 60s to accommodate slow Postgres database setup and migrations when running tests in parallel. This prevents false-positive failures on slower CI runners.

[gemini-code-assist]

Summary of Changes

Hello @gijswijs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves several intermittent test failures within the watchtower client and invoice test suites. It specifically targets race conditions in watchtower tests by introducing better synchronization mechanisms and enhances the robustness of invoice tests by extending their timeout period, leading to more reliable and stable test results across various environments.

Highlights

• Watchtower Client Test Synchronization: Introduced a "dialStarted" channel in "testRemoveLockedAddr" to ensure the tower dial initiates before verifying the address lock state, resolving a race condition.
• Watchtower Client Test Robustness: Modified "testTowerSwitch" to use "wait.Predicate" when calling "RemoveTower", accounting for scenarios where an address might still be locked by an active session.
• Invoice Test Timeout Adjustment: Increased the timeout for invoice tests from 10 seconds to 60 seconds to prevent false-positive failures on slower CI environments, particularly those involving Postgres database setup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses flaky tests in the watchtower and invoice packages. The changes involve increasing a test timeout to handle slow database setups, and adding proper synchronization mechanisms (a channel for signaling and a predicate loop for retries) to fix race conditions in watchtower tests. The fixes are logical and well-implemented. I have one minor suggestion regarding code style to improve readability.