DEVOPS-3640-added-runtime-collector-component - #257
Draft
Tal-Levy-Lightrun wants to merge 8 commits into
Draft
Conversation
Add the Runtime Collector component and its ClickHouse backend, which can be deployed locally by the chart or connected to an external instance (managed cloud or operator-provisioned, optionally clustered). The component is disabled by default, so rendering is unchanged for existing installations. Notable behaviours worth reviewing: - The ClickHouse credentials secret is only created when both the username and the password are set. Leaving either empty means the secret is expected to already exist, so credentials can be kept out of the values file even with deploy_secrets enabled. - CLICKHOUSE_DB is intentionally not set on the ClickHouse container. It makes the upstream entrypoint connect to itself with a plaintext client, which breaks once TLS moves the native port to tcp_port_secure. The database is created by the migrations init container instead. - Under readOnlyRootFilesystem an init container stages /etc/clickhouse-server into a writable volume, because the entrypoint rewrites its user config on every start. - Certificate verification is skipped only when verification is explicitly disabled, rather than whenever no CA happens to be mounted. Local ClickHouse with verification enabled and no CA secret is rejected at install time. Co-authored-by: Cursor <cursoragent@cursor.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 24589520 | Triggered | Generic Password | c19bc1c | .pipelines/helm-chart-validation.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Verified TLS to ClickHouse could never succeed: migrate is a Go binary and builds its trust store from SSL_CERT_FILE, so the mounted CA was ignored and the certificate rejected against the image's system CAs. Point the CA at SSL_CERT_FILE and drop the chart-invented SSL_CA_CERT_FILE, which nothing read. Own the ClickHouse PVC the same way as the rest of the chart, through an existingClaim the user creates, so the data lifecycle is independent of the release instead of being destroyed on helm uninstall. Collapse the two overlapping internal-TLS validations into one helper; they previously fired in the same situation with contradictory advice. Co-authored-by: Cursor <cursoragent@cursor.com>
Mount the ClickHouse CA based on the certificate source rather than on certificates.verification. The collector uses ClickHouse client-v2 0.9.8, which offers no way to disable certificate verification (setSSLMode arrives in 0.10.0, still pre-release), so a trust anchor is mandatory wherever TLS is used and verification: false cannot be honoured on this path. Self-signed certificates now mount the CA the release already generates for Keycloak, which makes TLS to a local ClickHouse work at all: previously no CA was mounted and the connection could neither verify nor skip verifying. Existing certificates without a named CA are now rejected at install time instead of rendering a deployment that cannot connect. Verified against a real TLS ClickHouse: setRootCertificate trusts the private CA and rejects an unrelated one, and clickhouse client honours SSL_CERT_FILE. Co-authored-by: Cursor <cursoragent@cursor.com>
Treat the ClickHouse secret like backend/keycloak: create it whenever deploy_secrets is enabled, and only honour existing_secrets.clickhouse when deploy_secrets is disabled. Co-authored-by: Cursor <cursoragent@cursor.com>
Use Guaranteed QoS defaults for every runtime-collector and local ClickHouse container by aligning resource requests with limits. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
… secret (#262) Co-authored-by: Tal Levy <tal@LTR132.local> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.