Skip to content

Conversation

@AkihiroSuda
Copy link
Member

Fix #4334

This PR also deprecates $LIMA_SSH_OVER_VSOCK and moves it to a YAML field .ssh.overVsock.

The environment variable is now deprecated but still supported

Signed-off-by: Akihiro Suda <[email protected]>
@norio-nomura
Copy link
Contributor

Well, I thought it would be like this.
I thought that there would come a time to write a similar PR so that I could set it up without using usernet, so I'm lucky that I don't need to write it anymore. :-)

What should I do with #4333?
In order to change the execution method of /usr/bin/ssh, we have to modify sshocker, so I guess I postpone it.

@AkihiroSuda
Copy link
Member Author

What should I do with #4333? In order to change the execution method of /usr/bin/ssh, we have to modify sshocker, so I guess I postpone it.

We may consider #4333 (and #4337) for v2.1+, but I'm still worried about the maintenance cost:

@norio-nomura
Copy link
Contributor

We may consider #4333 (and #4337) for v2.1+, but I'm still worried about the maintenance cost:

The failure of CI should decrease, but I don't know how much it will decrease.
I don't know how to estimate the increase in maintenance costs, so I don't think I can compare either of them.

Copy link
Contributor

@norio-nomura norio-nomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@jandubois jandubois merged commit 68be6f2 into lima-vm:master Nov 21, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template podman/fedora is no longer able to SSH

3 participants