Simplify CI #89
Simplify CI #89
Conversation
nirs
force-pushed
the
simpler-ci
branch
3 times, most recently
from
e3afd13 to
235ebb5
Compare
Adding or removing a version should be one line change now. Signed-off-by: Nir Soffer <[email protected]>
Signed-off-by: Nir Soffer <[email protected]>
nirs
force-pushed
the
simpler-ci
branch
2 times, most recently
from
08224ba to
6b187d3
Compare
|
Moving to draft to test standard qemu |
nirs
force-pushed
the
simpler-ci
branch
4 times, most recently
from
aa8cd34 to
011767b
Compare
| with: | ||
| fetch-depth: 1 | ||
| - name: Build | ||
| run: make |
There was a problem hiding this comment.
make test.repro should be tested
There was a problem hiding this comment.
I think I copied it from #63. You want to replace with make with make test.repro?
There was a problem hiding this comment.
The release workflow run make test.repro why test it here again? If we want to test this on all architectures we can add more platforms to the release matrix.
.github/workflows/release.yaml
Outdated
| # Apache License 2.0 | ||
|
|
||
| name: Release | ||
| name: release |
There was a problem hiding this comment.
For consistency with other names.
nirs
force-pushed
the
simpler-ci
branch
2 times, most recently
from
cd30669 to
4a88de7
Compare
.github/workflows/qemu.yaml
Outdated
| platform: | ||
| - macos-13-large | ||
| - macos-14-large | ||
| - macos-15-large |
There was a problem hiding this comment.
QEMU test is quite lightweight and should be executable on ARM Mac with QEMU TCG mode
There was a problem hiding this comment.
So, you can just merge qemu.yaml to build.yaml
There was a problem hiding this comment.
I can switch to arm, but I don't want to mix integration tests with trivial build. This test is likely to break in the future and will requires workaround, lets keep it separate.
There was a problem hiding this comment.
Updated to run with arm64 machines, kept as separate workflow for easier future maintainance.
nirs
force-pushed
the
simpler-ci
branch
2 times, most recently
from
6e151b7 to
56628c7
Compare
nirs
force-pushed
the
simpler-ci
branch
2 times, most recently
from
43cdc25 to
0aa2fa7
Compare
- build: build on multiple version of macOS - lima: lima integration tests - qemu: lima integration tests - release: already exist Try to run integration tests on all platforms to see what works now. We probably want to minimize the number of platform since the macOS runners are very flaky. The lima workflow is flaky. Sometimes all 3 platforms succeed, but usually one gets stuck and cancelled after many minutes. Notes: - Workflow names unified to Title case. This is more consistent with github UI and standard workflow names. Workarounds: - on macos-15-large brew is not updated and get lima 0.23.2. Fixed by running brew update. Signed-off-by: Nir Soffer <[email protected]>
It works now on macos-{13,14,15} in both standard and large runners.
This job is very quick so we run it on the standard runners.
Signed-off-by: Nir Soffer <[email protected]>
2 participants
Split CI to multiple workflow so we can run qemu and lima integration tests
without conflicts on all platforms.
Try to run integration tests on all platforms to see what works now. We
probably want to minimize the number of platform since the macOS runners
are very flaky.
The lima workflow is flaky. Sometimes all 3 platforms succeed, but
usually one gets stuck and cancelled after many minutes.
Notes:
github UI and standard workflow names.
Workarounds:
running brew update.