feat(macro): Add arg macro tests, docs and typings#2292
feat(macro): Add arg macro tests, docs and typings#2292DeyLak wants to merge 2 commits intolingui:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
- Coverage 77.05% 77.01% -0.04%
==========================================
Files 84 89 +5
Lines 2157 2506 +349
Branches 555 651 +96
==========================================
+ Hits 1662 1930 +268
- Misses 382 461 +79
- Partials 113 115 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Regardless of the original conversation we had, i feel that this PR is still quite a valuable contribution for the library, so would like to move this forward. The PR itself LGTM |
|
I'd like to do some changes first, than will mark as ready |
|
I added support for named placeholders to the arg macro, to be consistent with other places and added type tests for that. |
|
@andrii-bodnar anything else to be done to merge it? |
|
@timofei-iatsenko I was waiting here for lingui/swc-plugin#161, to release them synchronously |
Description
This PR resolves part of the discussed changes in #2279. It adds tests, docs and typings for the
argmacro that was already available in the babel plugin.Types of changes
Fixes #2279
Checklist