Add support for test notification endpoints - #9
Merged
Merged
Conversation
Owner
|
Thanks for contributing ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for making this library!
I found it really useful for adding support for App Store server-side API integration.
The
JWSValidationhelpers are also really useful for implementing push notifications.While testing push notifications end-to-end, I found it helpful to add support for the test notification endpoints to the client library.
Hope this is helpful for others as well.
I also noticed a small typo in the README, re: the response payload of
generate_tokenwhich returns a tuple, so went ahead and fixed that example while I was at it.