Skip to content

Conversation

@LZD-PratyushBhatt
Copy link
Collaborator

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)

Currently, Helix provides:

  • ResourceMonitor.PartitionGauge - partitions per resource (cluster-wide)
  • PerInstanceResourceMonitor.PartitionGauge - partitions per instance per resource

However, there was no way to quickly determine the total partition workload on a single instance across all resources without manually aggregating PerInstanceResourceMonitor metrics.

This PR adds two new instance-level metrics to track partition distribution and workload across Helix instances. These metrics fill a gap in the existing monitoring infrastructure by providing aggregated partition counts at the instance level.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)

New Metrics

  1. PartitionCount - Total number of partitions assigned to an instance across all resources
  2. TopStatePartitionCount - Number of partitions where the instance holds the top state (MASTER in MasterSlave, LEADER in LeaderStandby, etc.)

Tests

Unit tests added: TestInstanceMonitor.java
Manually tested as well on a real Helix cluster. Added/removed the resources to check if the metric is functioning properly.
image

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Collaborator

@proud-parselmouth proud-parselmouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

new HashMap<>(bestPossibleStates.getResourceMap(resource));
StateModelDefinition stateModelDef = stateModelDefMap.get(
resourceMap.get(resource).getStateModelDefRef());
String topState = null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:can we just do String topState = stateModelDef.getTopState()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants