fix(tests): nest structured annotation payload under value - #266
Open
noelmcloughlin wants to merge 3 commits into
Open
fix(tests): nest structured annotation payload under value#266noelmcloughlin wants to merge 3 commits into
value#266noelmcloughlin wants to merge 3 commits into
Conversation
matentzn
reviewed
Aug 5, 2026
matentzn
left a comment
matentzn
left a comment
Contributor
There was a problem hiding this comment.
The change is good, but why dont we take this opportunity to hard fail in tests/test_input_against_model.py? Like this it also wont happen again... If I know go and add the same wrong modelling to a new test it will just be ignored again..
self.assertEqual(nfailures, 0, f"{nfailures} input file(s) failed to load")
Contributor
Author
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #linkml/linkml#3809
value(range AnyValue) preserves the structure and lets the file loadtests/test_input_against_model.pywhen counted failures