Skip to content

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Dec 2, 2025

📌 Summary

This PR fixes workload values loading issue (keeps comment lines + raw value support) and resolves an issue where the getAll<resource> call caused console resource statuses to remain stuck on loading.

Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if it works with branch APL-1288? In there I removed the repo.ts file and we load the contents of the workload values in raw. But I think I use the loadYaml function.
If it does not work I think its better to create a new function then adjusting this loadYaml function and make it more complex

@ferruhcihan ferruhcihan added the on hold Waiting for another party to do something label Dec 3, 2025
@ferruhcihan
Copy link
Collaborator Author

Could you check if it works with branch APL-1288? In there I removed the repo.ts file and we load the contents of the workload values in raw. But I think I use the loadYaml function. If it does not work I think its better to create a new function then adjusting this loadYaml function and make it more complex

I think we can wait for the APL-1288 changes before merging this PR. After that, this PR will need some updates.

@ferruhcihan ferruhcihan removed the on hold Waiting for another party to do something label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants