-
Notifications
You must be signed in to change notification settings - Fork 33
[deprecation] Add v1beta1 CRDs for LinodeMachine and LinodeCluster #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AshleyDumaine
wants to merge
5
commits into
main
Choose a base branch
from
v1beta1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyDumaine
commented
Oct 28, 2025
b17885f to
28e3622
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
==========================================
- Coverage 66.34% 65.77% -0.57%
==========================================
Files 71 81 +10
Lines 7961 6426 -1535
==========================================
- Hits 5282 4227 -1055
+ Misses 2378 1898 -480
Partials 301 301 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Solidifies the CRD specs for the first beta version for LinodeMachine and LinodeCluster. This adds conversion webhooks to move from v1alpha2 to v1beta1 with the goal to eventually remove v1alpha2 CRDs.
CRDs to handle:
To handle in follow-up PRs
NOTE: Once the CRD specs are solidified, the controllers should be updated to use the v1beta1 APIs (which will be the storage version even if the deprecated v1alpha2 CRDs are used)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: