Skip to content

Conversation

@komer3
Copy link
Contributor

@komer3 komer3 commented Sep 17, 2025

📝 Description

What does this PR do and why is this change necessary?
Adding support for the new RuleSet api endpoints for firewalls

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?
Added the relevant unit and integration test. You can run make test to run them.

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@zliang-akamai zliang-akamai requested a review from Copilot October 13, 2025 22:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Firewall RuleSet functionality to the linodego client library. The implementation provides complete CRUD operations for managing firewall rule sets, which are collections of firewall rules that can be grouped and managed as a unit.

  • Added new RuleSet type with support for inbound/outbound rule collections
  • Implemented CRUD operations: List, Create, Get, Update, and Delete for firewall rule sets
  • Enhanced FirewallRule type to support rule set references via a new Ruleset field

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
firewall_rulesets.go Core implementation of RuleSet type and CRUD operations
firewall_rules.go Enhanced FirewallRule with ruleset reference support and custom JSON marshaling
test/unit/firewall_rulesets_test.go Comprehensive unit tests covering all RuleSet operations
test/unit/firewall_rules_test.go Added JSON marshaling tests for FirewallRule
test/integration/firewall_rulesets_test.go Integration test for complete CRUD workflow
test/integration/fixtures/TestFirewallRuleSets_CRUD.yaml Test fixture data for integration tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@komer3 komer3 changed the title [WIP] Add Firewall RuleSet support Add Firewall RuleSet support Oct 13, 2025
@komer3 komer3 marked this pull request as ready for review October 13, 2025 22:34
@komer3 komer3 requested a review from a team as a code owner October 13, 2025 22:34
@komer3 komer3 requested review from vshanthe and zliang-akamai and removed request for a team October 13, 2025 22:34
@lgarber-akamai lgarber-akamai self-requested a review October 14, 2025 14:46
…hat was a bug in the API that has been fixed and will be deployed with next release
@lgarber-akamai
Copy link
Contributor

@komer3 Is there any chance you could re-point this PR at the tmp-firewall-ruleset branch? Once the feature is available in production we can put up a PR to merge that branch into main.

@komer3 komer3 changed the base branch from main to tmp-firewall-ruleset October 23, 2025 16:58
@lgarber-akamai
Copy link
Contributor

lgarber-akamai commented Oct 30, 2025

@komer3 This looks great!

One small thing: could the events from section 7.8 be added to the EventAction const?

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! CI failures are unrelated and will be resolved in #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants