-
Notifications
You must be signed in to change notification settings - Fork 98
Add Firewall RuleSet support #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: tmp-firewall-ruleset
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Firewall RuleSet functionality to the linodego client library. The implementation provides complete CRUD operations for managing firewall rule sets, which are collections of firewall rules that can be grouped and managed as a unit.
- Added new
RuleSettype with support for inbound/outbound rule collections - Implemented CRUD operations: List, Create, Get, Update, and Delete for firewall rule sets
- Enhanced
FirewallRuletype to support rule set references via a newRulesetfield
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| firewall_rulesets.go | Core implementation of RuleSet type and CRUD operations |
| firewall_rules.go | Enhanced FirewallRule with ruleset reference support and custom JSON marshaling |
| test/unit/firewall_rulesets_test.go | Comprehensive unit tests covering all RuleSet operations |
| test/unit/firewall_rules_test.go | Added JSON marshaling tests for FirewallRule |
| test/integration/firewall_rulesets_test.go | Integration test for complete CRUD workflow |
| test/integration/fixtures/TestFirewallRuleSets_CRUD.yaml | Test fixture data for integration tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…hat was a bug in the API that has been fixed and will be deployed with next release
|
@komer3 Is there any chance you could re-point this PR at the |
|
@komer3 This looks great! One small thing: could the events from section 7.8 be added to the EventAction const? |
lgarber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! CI failures are unrelated and will be resolved in #843
📝 Description
What does this PR do and why is this change necessary?
Adding support for the new RuleSet api endpoints for firewalls
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
Added the relevant unit and integration test. You can run
make testto run them.📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.