Skip to content

Conversation

@zliang-akamai
Copy link
Member

📝 Description

  • Add resource prefix for resource schema attribute variables, in order to distinguish them with the incoming data source variables.
  • Remove not configurable attribute route_target in the configured IPv6 attribute.
  • Add multiple custom types for IP addresses and ranges.
  • Remove UseStateForUnknown plan modifier for shared IP addresses because we can't be certain during an update operation if a new shared IP is assigned to the interface.

✔️ How to Test

make test-int PKG_NAME=linodeinterface PARALLEL=5

@zliang-akamai zliang-akamai requested a review from a team as a code owner November 4, 2025 07:08
@zliang-akamai zliang-akamai requested review from Copilot, jriddle-linode and lgarber-akamai and removed request for a team November 4, 2025 07:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements multiple improvements to the Linode interface resource, focusing on better variable organization, schema refinements, and type safety enhancements.

  • Adds resource prefix to schema attribute variables to distinguish them from future data source variables
  • Removes the non-configurable route_target attribute from configured IPv6 ranges and adds custom IP type validation
  • Introduces separate model types for configured vs computed IPv6 ranges to better represent their different schemas

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
framework_resource_schema.go Renames schema variables with resource prefix, removes route_target from configured ranges, adds custom IP types
framework_public_models.go Splits IPv6 range model into separate configured/computed types, updates variable references
framework_vpc_models.go Updates variable references to use new resource-prefixed names
framework_models.go Updates variable references to use new resource-prefixed names
interface.md Removes documentation for the route_target attribute that was removed from configured ranges

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant