Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Nov 11, 2025

Previously, CI would download the standard-inventory-qcow2 script from pagure. However,
the pagure download url is now being protected by Anubis which by default
will check the User-Agent header and deny attempts from clients that look
like scrapers or hackers. Rather than trying to play arms race with setting
headers, etc. - just move this script to tox-lsr. If we really need to sync
with the upstream development, we can do that manually.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Bump the tox-lsr dependency to 3.14.0 across all CI workflows to include the relocated standard-inventory-qcow2 script and avoid external downloads via pagure.

New Features:

  • Relocate standard-inventory-qcow2 into the tox-lsr package to remove external pagure downloads

CI:

  • Update tox-lsr installation to version 3.14.0 in all GitHub Actions workflows

…ox-lsr

Previously, CI would download the standard-inventory-qcow2 script from pagure.  However,
the pagure download url is now being protected by Anubis which by default
will check the User-Agent header and deny attempts from clients that look
like scrapers or hackers. Rather than trying to play arms race with setting
headers, etc. - just move this script to tox-lsr. If we really need to sync
with the upstream development, we can do that manually.

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from spetrosi as a code owner November 11, 2025 13:51
@richm richm self-assigned this Nov 11, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR bumps the tox-lsr dependency from v3.13.0 to v3.14.0 across all GitHub CI workflows, consolidating the standard-inventory-qcow2 script into the tox-lsr package and eliminating external downloads.

Flow diagram for standard-inventory-qcow2 script sourcing change in CI

flowchart TD
  A["CI Workflow starts"] --> B["Install tox-lsr v3.13.0"]
  B --> C["Download standard-inventory-qcow2 from pagure"]
  C -. replaced by .-> D["Install tox-lsr v3.14.0"]
  D --> E["Use standard-inventory-qcow2 from tox-lsr package"]
Loading

File-Level Changes

Change Details Files
Bump pip3-based tox-lsr installs to v3.14.0
  • Replace '@3.13.0' with '@3.14.0' in pip3 install commands
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/qemu-kvm-integration-tests.yml
Bump pip-based tox-lsr install to v3.14.0
  • Replace '@3.13.0' with '@3.14.0' in pip install command
.github/workflows/python-unit-test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The tox-lsr version is hard-coded in multiple workflow files; consider centralizing it (e.g., via a shared variable or workflow template) to simplify future upgrades.
  • Since the standard-inventory-qcow2 script has moved into tox-lsr, verify that CI still invokes it correctly and that any project-specific adjustments are intact.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The tox-lsr version is hard-coded in multiple workflow files; consider centralizing it (e.g., via a shared variable or workflow template) to simplify future upgrades.
- Since the standard-inventory-qcow2 script has moved into tox-lsr, verify that CI still invokes it correctly and that any project-specific adjustments are intact.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 6533290 into main Nov 11, 2025
29 checks passed
@richm richm deleted the tox-lsr-3.14.0 branch November 11, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants